Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update USAGE.md to prevent query double encoding #878

Merged
merged 1 commit into from
Feb 13, 2020

Conversation

SGudbrandsson
Copy link
Contributor

@SGudbrandsson SGudbrandsson commented Jan 22, 2019

The documentation recommends urlencoding data when checking message activity.

This causes a double encoding problem.

Fixes

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the development branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • Updates documentation to prevent double encoding of queries

If you have questions, please send an email to SendGrid, or file a Github Issue in this repository.

The documentation recommends urlencoding data when checking message activity.

This causes a double encoding problem.
@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Jan 22, 2019
@SendGridDX
Copy link
Collaborator

SendGridDX commented Jan 22, 2019

CLA assistant check
All committers have signed the CLA.

@childish-sambino childish-sambino force-pushed the master branch 5 times, most recently from 389fa8c to 37473ad Compare January 15, 2020 21:44
@childish-sambino childish-sambino changed the title Update USAGE.md to prevent query double encoding docs: Update USAGE.md to prevent query double encoding Feb 13, 2020
@childish-sambino childish-sambino merged commit 1b3a81f into sendgrid:master Feb 13, 2020
@thinkingserious
Copy link
Contributor

Hello @sigginet,

Thanks again for the PR!

We want to show our appreciation by sending you some swag. Could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: code review request requesting a community code review or review from Twilio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants