Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Properly capitalize Brands #825

Merged
merged 1 commit into from
Feb 13, 2020
Merged

docs: Properly capitalize Brands #825

merged 1 commit into from
Feb 13, 2020

Conversation

aslafy-z
Copy link
Contributor

Properly capitalize SendGrid and GitHub

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 27, 2018
@aslafy-z aslafy-z force-pushed the patch-6 branch 2 times, most recently from 00d9ebb to 7effec6 Compare October 27, 2018 05:14
@Ditofry Ditofry added hacktoberfest difficulty: easy fix is easy in difficulty labels Oct 30, 2018
@Ditofry
Copy link

Ditofry commented Oct 30, 2018

@aslafy-z looks like you're conflicting with some of your own work done in #809 :)

Would you mind fixing, please?

Ditofry
Ditofry suggested changes Oct 30, 2018
View reviewed changes
Copy link

@Ditofry Ditofry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge Conflicts

@aslafy-z aslafy-z changed the title Properly capitalize Brands Properly capitalize "GitHub" brand Oct 31, 2018
@aslafy-z
Capitalize GitHub
653651b 
Signed-off-by: Zadkiel Aharonian <[email protected]>
@aslafy-z aslafy-z changed the title Properly capitalize "GitHub" brand Properly capitalize Brands Oct 31, 2018
@childish-sambino childish-sambino force-pushed the master branch 5 times, most recently from 389fa8c to 37473ad Compare January 15, 2020 21:44
@childish-sambino childish-sambino changed the title Properly capitalize Brands docs: Properly capitalize Brands Feb 13, 2020
@childish-sambino childish-sambino merged commit 653651b into sendgrid:master Feb 13, 2020
@thinkingserious
Copy link
Contributor

Hello @aslafy-z,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

@snyk-bot snyk-bot mentioned this pull request Mar 19, 2020
Merged
@snyk-bot snyk-bot mentioned this pull request Apr 2, 2020
Merged
This was referenced Apr 17, 2020
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ditofry Ditofry Ditofry requested changes

@childish-sambino childish-sambino childish-sambino approved these changes

Assignees
No one assigned
Labels
difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aslafy-z @Ditofry @thinkingserious @childish-sambino