docs: specify custom arguments must have string values #784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thinkingserious
added
the
status: code review request
|
|
reedsa
reviewed
Oct 10, 2018
use-cases/kitchen-sink.md
Outdated
| @@ -48,3 +48,7 @@ sgMail | |||
| .then(() => console.log('Mail sent successfully')) | |||
| .catch(error => console.error(error.toString())); | |||
| ``` | |||
|
|
|||
| ### Error Handling: | |||
There was a problem hiding this comment.
Not a big deal but perhaps this title should be Caveats?
There was a problem hiding this comment.
agreed @reedsa , I'll update the PR
reedsa
added
status: waiting for feedback
devchas
added
hacktoberfest
difficulty: easy
reedsa
approved these changes
Oct 15, 2018
reedsa
added
status: ready for deploy
|
Hi @reedsa, can this be merged in? |
This was referenced Apr 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #658
Checklist
Short description of what this PR does:
customArgsfield in the docs to reflect that it takes only string valueIf you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.
cc @thinkingserious