Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v3 send email broken link fixed in TROUBLESHOOTING.md #780

Merged
merged 1 commit into from
Oct 22, 2018
Merged

v3 send email broken link fixed in TROUBLESHOOTING.md #780

merged 1 commit into from
Oct 22, 2018

Conversation

arshadkazmi42
Copy link
Contributor

@arshadkazmi42 arshadkazmi42 commented Oct 6, 2018 •
edited
Loading

Fixes #782

Checklist

  • [ x] I have made a material change to the repo (functionality, testing, spelling, grammar)
  • [ x] I have read the [Contribution Guide] and my PR follows them.
  • [ x] I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • Fixed v3 email example broken link

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 6, 2018
reedsa
reedsa approved these changes Oct 10, 2018
View reviewed changes
Copy link
Contributor

@reedsa reedsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for the PR 👍

@reedsa reedsa added status: ready for deploy code ready to be released in next deploy and removed status: code review request requesting a community code review or review from Twilio labels Oct 10, 2018
@devchas devchas added the status: work in progress Twilio or the community is in the process of implementing label Oct 17, 2018
@thinkingserious thinkingserious added hacktoberfest difficulty: easy fix is easy in difficulty type: docs update documentation change not affecting the code and removed status: work in progress Twilio or the community is in the process of implementing labels Oct 22, 2018
@thinkingserious thinkingserious merged commit 2f533a3 into sendgrid:master Oct 22, 2018
@arshadkazmi42 arshadkazmi42 deleted the troubleshooting-broken-link branch October 23, 2018 03:30
@snyk-bot snyk-bot mentioned this pull request Dec 5, 2019
Open
@snyk-bot snyk-bot mentioned this pull request Feb 7, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Mar 19, 2020
Merged
This was referenced Apr 17, 2020
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reedsa reedsa reedsa approved these changes

Assignees
No one assigned
Labels
difficulty: easy fix is easy in difficulty status: ready for deploy code ready to be released in next deploy type: docs update documentation change not affecting the code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix broken link in TROUBLESHOOTING.md
4 participants
@arshadkazmi42 @reedsa @thinkingserious @devchas