Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repository overview sendgrid #628

Merged

Conversation

nitish24p
Copy link
Contributor

@nitish24p nitish24p commented Nov 21, 2017

Fixes #608

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

Makes an overview of the repo so that any new developer has a starting point. :)

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Nov 21, 2017
@nitish24p
Copy link
Contributor Author

@thinkingserious please have a look, is the format ok.
Also i have had a look at mail, client and helpers, need some more info on the mail parser , contact importer and the widget.

Regards
Nitish

@nitish24p
Copy link
Contributor Author

@mbernier Your suggestions here would be great..

@thinkingserious
Copy link
Contributor

Hello @nitish24p,

One of us will be reviewing once this comes up next in our backlog. We are processing PRs from oldest to newest currently.

We apologize for the delay and appreciate your patience.

With Best Regards,

Elmer

@thinkingserious thinkingserious added difficulty: easy fix is easy in difficulty type: docs update documentation change not affecting the code labels Mar 6, 2018
@thinkingserious thinkingserious merged commit c095a9a into sendgrid:master Jun 14, 2018
@thinkingserious
Copy link
Contributor

Hello @nitish24p,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio type: docs update documentation change not affecting the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repo code overview documentation
2 participants