Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude esdoc node modules #610

Merged
merged 2 commits into from
Jun 14, 2018

Conversation

nitish24p
Copy link
Contributor

@nitish24p nitish24p commented Nov 7, 2017

Fixes

ESDOC command error. Currently Node modules also get documented, which is not what is intended, only packages part of this repo should get documented.

Fixes the error below
screen shot 2017-11-08 at 12 46 54 am

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • Esdoc command is breaking on some node modules. This PR updates esdoc config

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Nov 7, 2017
@thinkingserious
Copy link
Contributor

Thank you @nitish24p!

@thinkingserious thinkingserious added type: bug bug in the library difficulty: easy fix is easy in difficulty labels Mar 6, 2018
@thinkingserious thinkingserious merged commit fe9c7a6 into sendgrid:master Jun 14, 2018
@thinkingserious
Copy link
Contributor

Hello @nitish24p,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio type: bug bug in the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants