Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #507 as assigned to me in #332 #536

Closed
wants to merge 3 commits into from
Closed

fixes #507 as assigned to me in #332 #536

wants to merge 3 commits into from

Conversation

itaditya
Copy link
Contributor

@itaditya itaditya commented Oct 24, 2017 •
edited by mbernier
Loading

@mbernier edit
Closes #507
Closes #332

@itaditya
Copy link
Contributor Author

@mbernier, please review it.

@mbernier
Copy link
Contributor

HOLY ... This is awesome!! Thank you so much for doing this!!

@mbernier mbernier added difficulty: very hard fix is very hard in difficulty hacktoberfest labels Oct 28, 2017
@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 29, 2017
@thinkingserious thinkingserious added the type: twilio enhancement feature request on Twilio's roadmap label Mar 6, 2018
@itaditya
Copy link
Contributor Author

Hi @mbernier could you please take a look at this

@thinkingserious
Copy link
Contributor

Hello @itaditya,

I will be reviewing this one once it bubbles up to the top of our backlog. My apologies on the long delay.

With Best Regards,

Elmer

@itaditya
Copy link
Contributor Author

@thinkingserious no problem.

@thinkingserious thinkingserious mentioned this pull request Jul 31, 2018
Closed
@thinkingserious
Copy link
Contributor

Hello @itaditya,

I have begun reviewing this PR and I need a bit of help to speed the process:

  1. Could you please create a quick demo of what the final solution looks like in practice? Maybe using Jing or something similar.
  2. Please write up a section in the README that describes what this app does and how you would use it in practice.

Thank you!

With Best Regards,

Elmer

@thinkingserious thinkingserious added status: waiting for feedback waiting for feedback from the submitter and removed status: code review request requesting a community code review or review from Twilio labels Dec 6, 2018
@itaditya
Copy link
Contributor Author

itaditya commented Dec 7, 2018

@thinkingserious I'll try to get it done this week. Glad to hear the news 😄

@thinkingserious
Copy link
Contributor

Thank you @itaditya!

@childish-sambino childish-sambino force-pushed the master branch 5 times, most recently from 389fa8c to 37473ad Compare January 15, 2020 21:44
@childish-sambino childish-sambino removed the type: twilio enhancement feature request on Twilio's roadmap label Jul 20, 2020
@thinkingserious thinkingserious changed the base branch from master to main July 28, 2020 14:34
@childish-sambino
Copy link
Contributor

Closing due to inactivity. Please ping here if work is to continue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thinkingserious thinkingserious Awaiting requested review from thinkingserious

Assignees
No one assigned
Labels
difficulty: very hard fix is very hard in difficulty status: waiting for feedback waiting for feedback from the submitter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SendGrid Event Webhook consumer cant understand how to use code workshop sample
4 participants
@itaditya @mbernier @thinkingserious @childish-sambino