Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added how to deploy simple hello world app on Azure #490

Merged
merged 4 commits into from
Aug 28, 2018
Merged

Added how to deploy simple hello world app on Azure #490

merged 4 commits into from
Aug 28, 2018

Conversation

SarasArya
Copy link

@SarasArya SarasArya commented Oct 15, 2017 •
edited by thinkingserious
Loading

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 15, 2017
@SendGridDX
Copy link
Collaborator

SendGridDX commented Oct 15, 2017 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@SarasArya SarasArya mentioned this pull request Oct 15, 2017
Closed
@thinkingserious thinkingserious added difficulty: medium fix is medium in difficulty hacktoberfest labels Oct 23, 2017
@thinkingserious
Copy link
Contributor

Hi @SarasArya,

Could you please resolve the merge conflict?

Thanks!

With Best Regards,

Elmer

@clee clee added status: work in progress Twilio or the community is in the process of implementing and removed status: code review request requesting a community code review or review from Twilio status: work in progress Twilio or the community is in the process of implementing labels Feb 14, 2018
clee
clee suggested changes Feb 14, 2018
View reviewed changes
Copy link

@clee clee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @SarasArya! Thanks for the PR. Unfortunately, it looks like some other changes that were merged into the sendgrid-nodejs codebase have resulted in a merge conflict, so we need you to rebase your code. Once your PR applies cleanly to master, please let us know so that we can merge it!

@SarasArya
Copy link
Author

Hi @clee rebased with master branch. Please merge

@thinkingserious thinkingserious added type: docs update documentation change not affecting the code status: ready for deploy code ready to be released in next deploy labels Mar 6, 2018
@SarasArya
Copy link
Author

Hi whats the status on this?

@thinkingserious thinkingserious merged commit 6a169ae into sendgrid:master Aug 28, 2018
@thinkingserious
Copy link
Contributor

Hello @SarasArya,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

@snyk-bot snyk-bot mentioned this pull request Dec 5, 2019
Open
@snyk-bot snyk-bot mentioned this pull request Feb 7, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Mar 19, 2020
Merged
This was referenced Apr 17, 2020
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clee clee clee requested changes

Assignees
No one assigned
Labels
difficulty: medium fix is medium in difficulty status: ready for deploy code ready to be released in next deploy type: docs update documentation change not affecting the code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SarasArya @SendGridDX @thinkingserious @clee