Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle null and undefined values in substitutions #413

Merged
merged 1 commit into from
Aug 9, 2017
Merged

Handle null and undefined values in substitutions #413

merged 1 commit into from
Aug 9, 2017
+7 −1

Conversation

chamini2
Copy link
Contributor

After #410 we started getting errors like TypeError: Cannot read property 'toString' of null. This tests for null or undefined values and handles them as empty string.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Jul 27, 2017
@SendGridDX
Copy link
Collaborator

SendGridDX commented Jul 27, 2017 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@thinkingserious thinkingserious merged commit 3c4f82b into sendgrid:master Aug 9, 2017
@thinkingserious
Copy link
Contributor

Hello @chamini2,

Thanks again for the PR!

We want to show our appreciation by sending you some swag. Could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

thinkingserious added a commit that referenced this pull request Aug 9, 2017
@thinkingserious
Version Bump v5.2.1: Pull #413: Handle null and undefined values in s…
2079172 
…ubstitutions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status: code review request requesting a community code review or review from Twilio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chamini2 @SendGridDX @thinkingserious