Tkp/contact importer #278
Merged
Tkp/contact importer #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrfelton
force-pushed
the
tkp/contact-importer
branch
2 times, most recently
from
6a271ac to
162b6e2
Compare
mrfelton
force-pushed
the
tkp/contact-importer
branch
from
162b6e2 to
1dc832b
Compare
| }) | ||
|
|
||
|
|
||
| // assert.equal(sg.limiters['/v3/contactdb/recipients'].queue.length, 2) |
thinkingserious
added
type: community enhancement
|
Hi @mrfelton, Is this one ready for review to merge? |
|
@thinkingserious yes, we're using this helper class in production. It could probably do with some more unit tests, but it does it's thing. I just successfully used it to import 199,713 contacts into a Sendgrid account. |
|
@thinkingserious the changes in this PR were built ontop of the other one. It should apply cleanly ontop of it. |
|
Can you please send us your mailing address and T-shirt size to [email protected]? |
thinkingserious
added a commit
that referenced
this pull request
Sep 15, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial concept for a helper that automatically batches contacts into sets of 1500 and throttles the API usage to a maximum throughput of 3 requests per 2 seconds (the limit imposed by SendGrid). Results of each batch import are emitted as an event containing details of the batch (the contacts that were uploaded and the results of upload).
Addresses #273.
Note, this patch builds on work done in #275.