Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump Axios to 0.21.4 to fix ReDoS #1296

Merged
merged 1 commit into from
Sep 9, 2021
Merged

chore: Bump Axios to 0.21.4 to fix ReDoS #1296

merged 1 commit into from
Sep 9, 2021

Conversation

LuisOsta
Copy link
Contributor

@LuisOsta LuisOsta commented Sep 7, 2021

Fixes issue #1294 . Based on the discussion here. It actually seems that 0.21.4 is what's necessary to address the fix.

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

Fixes

I changed the version of axios that sendgrid client uses from 0.21.1 to 0.21.4.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

@LuisOsta
Copy link
Contributor Author

LuisOsta commented Sep 8, 2021

Thanks for the quick review! @bgdman

@LuisOsta
Copy link
Contributor Author

LuisOsta commented Sep 9, 2021

@bgdman Do you have a sense about when this fix will be merged in?

@shwetha-manvinkurke shwetha-manvinkurke merged commit a6eebb5 into sendgrid:main Sep 9, 2021
@childish-sambino
Copy link
Contributor

Unmarking this as breaking.

@childish-sambino childish-sambino changed the title chore!: Bump Axios to 0.21.4 to fix ReDoS chore: Bump Axios to 0.21.4 to fix ReDoS Sep 13, 2021
@LuisOsta LuisOsta mentioned this pull request Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants