Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Node 6 build failure #1257

Merged
merged 7 commits into from
Feb 24, 2021
Merged

fix: Node 6 build failure #1257

merged 7 commits into from
Feb 24, 2021

Conversation

thinkingserious
Copy link
Contributor

This change ensures that we don't pull in Chai v4.3.0 (which no longer supports Node 6) with npm install or yarn install.

Checklist

  • I acknowledge that all my contributions will be made under the project's license

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Feb 24, 2021
JenniferMah
JenniferMah approved these changes Feb 24, 2021
View reviewed changes
Copy link
Contributor

@JenniferMah JenniferMah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thinkingserious thinkingserious merged commit 72cfa0d into main Feb 24, 2021
@thinkingserious thinkingserious deleted the node6 branch February 24, 2021 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JenniferMah JenniferMah JenniferMah approved these changes

Assignees
No one assigned
Labels
status: code review request requesting a community code review or review from Twilio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thinkingserious @JenniferMah