Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: upgrade dev dependencies and fix eslint warnings/errors #1063

Merged
merged 4 commits into from
Mar 19, 2020
Merged

chore: upgrade dev dependencies and fix eslint warnings/errors #1063

merged 4 commits into from
Mar 19, 2020

Conversation

eshanholtz
Copy link
Contributor

No description provided.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Mar 12, 2020
eshanholtz
eshanholtz commented Mar 12, 2020
View reviewed changes
.travis.yml Outdated Show resolved Hide resolved
childish-sambino
childish-sambino reviewed Mar 13, 2020
View reviewed changes
packages/helpers/classes/attachment.js Outdated Show resolved Hide resolved
.travis.yml Outdated Show resolved Hide resolved
@eshanholtz eshanholtz changed the title chore: upgrade dev dependencies and fix eslint warnings/errors chore!: upgrade dev dependencies and fix eslint warnings/errors Mar 13, 2020
@eshanholtz eshanholtz mentioned this pull request Mar 16, 2020
Merged
@eshanholtz eshanholtz changed the title chore!: upgrade dev dependencies and fix eslint warnings/errors [DO NOT MERGE] chore!: upgrade dev dependencies and fix eslint warnings/errors Mar 18, 2020
childish-sambino
childish-sambino approved these changes Mar 19, 2020
View reviewed changes
Copy link
Contributor

@childish-sambino childish-sambino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Can drop the ! since it's no longer breaking!

@eshanholtz eshanholtz changed the title [DO NOT MERGE] chore!: upgrade dev dependencies and fix eslint warnings/errors [DO NOT MERGE] chore: upgrade dev dependencies and fix eslint warnings/errors Mar 19, 2020
@eshanholtz eshanholtz changed the title [DO NOT MERGE] chore: upgrade dev dependencies and fix eslint warnings/errors chore!: upgrade dev dependencies and fix eslint warnings/errors Mar 19, 2020
@eshanholtz eshanholtz merged commit 8075616 into master Mar 19, 2020
@eshanholtz eshanholtz deleted the dev-upgrade branch March 19, 2020 18:12
@eshanholtz eshanholtz changed the title chore!: upgrade dev dependencies and fix eslint warnings/errors chore: upgrade dev dependencies and fix eslint warnings/errors Mar 19, 2020
@snyk-bot snyk-bot mentioned this pull request Apr 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@childish-sambino childish-sambino childish-sambino approved these changes

Assignees
No one assigned
Labels
status: code review request requesting a community code review or review from Twilio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eshanholtz @childish-sambino @thinkingserious