Merge pull request #767 from tony-ho/style-conformance

Add conformance to style standards

.eslintignore

@@ -1,3 +1,4 @@
 node_modules
 examples
 test
+coverage

.eslintrc.yaml

@@ -173,7 +173,7 @@ rules:
   block-scoped-var: off
   class-methods-use-this: off
   complexity:
-    - error
+    - warn
     - 6
   consistent-return: off
   default-case: off
@@ -253,7 +253,7 @@ rules:
 
   # Node.js and CommonJS
   callback-return: error
-  global-require: error
+  global-require: off
   handle-callback-err: error
   no-mixed-requires: off
   no-new-require: off
@@ -282,7 +282,7 @@ rules:
   max-params: off
   max-statements-per-line: off
   max-statements:
-    - error
+    - warn
     - 30
   multiline-ternary: off
   new-parens: off

.travis.yml

@@ -20,6 +20,8 @@ script:
 - yarn test:client
 - yarn test:helpers
 - yarn test:typescript
+- yarn lint
+- yarn doc
 notifications:
   hipchat:
     rooms:

CONTRIBUTING.md

@@ -160,7 +160,13 @@ Generally, we follow the style guidelines as suggested by the official language.
 Please run your code through:
 
 - [ESLint](http://eslint.org/) with the standard style guide.
-- [esdoc](https://esdoc.org/) to check the documentation coverage of your added code.
+  ```bash
+  yarn lint
+  ```
+- [ESDoc](https://esdoc.org/) to check the documentation coverage of your added code.
+  ```bash
+  yarn doc
+  ```
 
 ## Creating a Pull Request<a name="creating-a-pull-request"></a>
 

package.json

@@ -25,6 +25,7 @@
     "typescript": "~2.4.2"
   },
   "scripts": {
+    "doc": "esdoc",
     "lint": "eslint . --fix",
     "prism:install": "curl https://raw.githubusercontent.com/stoplightio/prism/master/install.sh | sh",
     "prism": "prism run --mock --list --spec https://raw.githubusercontent.com/sendgrid/sendgrid-oai/master/oai_stoplight.json",

packages/inbound-mail-parser/src/parser.spec.js

@@ -31,7 +31,7 @@ describe('test_parse', () => {
       const parse = new Parse({}, {});
 
       function callback(email) {
-        expect(email).to.be.null;
+        expect(email).to.be.null();
         done();
       }
 

packages/mail/src/classes/mail-service.js

@@ -112,6 +112,7 @@ class MailService {
 
       //Pass to callback if provided
       if (cb) {
+        // eslint-disable-next-line callback-return
         cb(error, null);
       }