Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spelling corrections in md, xml docs and variable names #584

Merged
merged 1 commit into from
Oct 22, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ All notable changes to this project will be documented in this file.
## [9.8.0] - 2017-08-15
## Added
- Single email to multiple recipients - Toggle display of recipients #508
- The method `CreateSingleEmailToMultipleRecipients` now has an additional optional paramter to control whether the email recipients can see each others email addresses. Please see [USE_CASES.md](https://github.com/sendgrid/sendgrid-csharp/blob/master/USE_CASES.md#singleemailmultiplerecipients) for details.
- The method `CreateSingleEmailToMultipleRecipients` now has an additional optional parameter to control whether the email recipients can see each others email addresses. Please see [USE_CASES.md](https://github.com/sendgrid/sendgrid-csharp/blob/master/USE_CASES.md#singleemailmultiplerecipients) for details.
- Thanks to [Niladri Dutta](Niladri24dutta) for the PR!

## [9.7.0] - 2017-08-03
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ var apiKey = Environment.GetEnvironmentVariable("NAME_OF_THE_ENVIRONMENT_VARIABL

`NAME_OF_THE_ENVIRONMENT_VARIABLE_FOR_YOUR_SENDGRID_KEY` isn't a variable of your OS environment yet, so let's add it.

Press `win + R` (or search for "run"), fill in "SystemPropertiesAdvanced", press `enter` and then click "Enviroment variables".
Press `win + R` (or search for "run"), fill in "SystemPropertiesAdvanced", press `enter` and then click "Environment variables".

You'll get two lists of variables, but we'll focus on the User Variables for this example.

Expand Down
2 changes: 1 addition & 1 deletion USE_CASES.md
Original file line number Diff line number Diff line change
Expand Up @@ -612,7 +612,7 @@ The value that will be used to calculate a random delta in the exponential delay

## Examples

In this example we are setting RetryCount to 2, with a mimimum wait time of 1 seconds, a maximum of 10 seconds and a delta of 3 seconds
In this example we are setting RetryCount to 2, with a minimum wait time of 1 seconds, a maximum of 10 seconds and a delta of 3 seconds

```csharp

Expand Down
20 changes: 10 additions & 10 deletions src/SendGrid/Helpers/Mail/SendGridMessage.cs
Original file line number Diff line number Diff line change
Expand Up @@ -697,7 +697,7 @@ public void AddSubstitution(string substitutionKey, string substitutionValue, in
/// <summary>
/// Add substitutions to the email.
/// </summary>
/// <param name="substitutions">A list of Substituions.</param>
/// <param name="substitutions">A list of Substitutions.</param>
/// <param name="personalizationIndex">Specify the index of the Personalization object where you want to add the substitutions.</param>
/// <param name="personalization">A personalization object to append to the message.</param>
public void AddSubstitutions(Dictionary<string, string> substitutions, int personalizationIndex = 0, Personalization personalization = null)
Expand Down Expand Up @@ -748,10 +748,10 @@ public void AddSubstitutions(Dictionary<string, string> substitutions, int perso
}

/// <summary>
/// Add a custom arguement to the email.
/// Add a custom argument to the email.
/// </summary>
/// <param name="customArgKey">The custom arguement key.</param>
/// <param name="customArgValue">The custom arguement value.</param>
/// <param name="customArgKey">The custom argument key.</param>
/// <param name="customArgValue">The custom argument value.</param>
/// <param name="personalizationIndex">Specify the index of the Personalization object where you want to add the custom arg.</param>
/// <param name="personalization">A personalization object to append to the message.</param>
public void AddCustomArg(string customArgKey, string customArgValue, int personalizationIndex = 0, Personalization personalization = null)
Expand Down Expand Up @@ -803,7 +803,7 @@ public void AddCustomArg(string customArgKey, string customArgValue, int persona
}

/// <summary>
/// Add custom arguements to the email.
/// Add custom arguments to the email.
/// </summary>
/// <param name="customArgs">A list of CustomArgs.</param>
/// <param name="personalizationIndex">Specify the index of the Personalization object where you want to add the custom args.</param>
Expand Down Expand Up @@ -1169,9 +1169,9 @@ public void AddCategories(List<string> categories)
}

/// <summary>
/// Add a global custom arguement.
/// Add a global custom argument.
/// </summary>
/// <param name="key">The custom arguement key. The value of this key will be overridden by custom args at the personalization level.</param>
/// <param name="key">The custom arguments key. The value of this key will be overridden by custom args at the personalization level.</param>
/// <param name="value">The custom argument value.</param>
public void AddGlobalCustomArg(string key, string value)
{
Expand All @@ -1191,7 +1191,7 @@ public void AddGlobalCustomArg(string key, string value)
}

/// <summary>
/// Add global custom arguements.
/// Add global custom arguments.
/// </summary>
/// <param name="customArgs">A list of CustomArgs.</param>
public void AddGlobalCustomArgs(Dictionary<string, string> customArgs)
Expand Down Expand Up @@ -1505,7 +1505,7 @@ public string Serialize()
}
}

var jsonSeriazerSettings = new JsonSerializerSettings
var jsonSerializerSettings = new JsonSerializerSettings
{
NullValueHandling = NullValueHandling.Ignore,
DefaultValueHandling = DefaultValueHandling.Include,
Expand All @@ -1515,7 +1515,7 @@ public string Serialize()
return JsonConvert.SerializeObject(
this,
Formatting.None,
jsonSeriazerSettings);
jsonSerializerSettings);
}
}
}
4 changes: 2 additions & 2 deletions src/SendGrid/ISendGridClient.cs
Original file line number Diff line number Diff line change
Expand Up @@ -63,10 +63,10 @@ public interface ISendGridClient
Task<Response> RequestAsync(SendGridClient.Method method, string requestBody = null, string queryParams = null, string urlPath = null, CancellationToken cancellationToken = default(CancellationToken));

/// <summary>
/// Make a request to send an email through SendGrid asychronously.
/// Make a request to send an email through SendGrid asynchronously.
/// </summary>
/// <param name="msg">A SendGridMessage object with the details for the request.</param>
/// <param name="cancellationToken">Cancel the asychronous call.</param>
/// <param name="cancellationToken">Cancel the asynchronous call.</param>
/// <returns>A Response object.</returns>
Task<Response> SendEmailAsync(SendGridMessage msg, CancellationToken cancellationToken = default(CancellationToken));
}
Expand Down
2 changes: 1 addition & 1 deletion src/SendGrid/Reliability/RetryDelegatingHandler.cs
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ public RetryDelegatingHandler(ReliabilitySettings settings)
/// <summary>
/// Initializes a new instance of the <see cref="RetryDelegatingHandler"/> class.
/// </summary>
/// <param name="innerHandler">A HttpMessageHandler instance to set as the innner handler</param>
/// <param name="innerHandler">A HttpMessageHandler instance to set as the inner handler</param>
/// <param name="settings">A ReliabilitySettings instance</param>
public RetryDelegatingHandler(HttpMessageHandler innerHandler, ReliabilitySettings settings)
: base(innerHandler)
Expand Down
2 changes: 1 addition & 1 deletion src/SendGrid/Response.cs
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ public virtual Dictionary<string, dynamic> DeserializeResponseBody(HttpContent c
/// Converts string formatted response headers to a Dictionary.
/// </summary>
/// <param name="content">https://msdn.microsoft.com/en-us/library/system.net.http.headers.httpresponseheaders(v=vs.118).aspx</param>
/// <returns>Dictionary object representation of HttpRepsonseHeaders</returns>
/// <returns>Dictionary object representation of HttpResponseHeaders</returns>
public virtual Dictionary<string, string> DeserializeResponseHeaders(HttpResponseHeaders content)
{
var dsContent = new Dictionary<string, string>();
Expand Down
6 changes: 3 additions & 3 deletions src/SendGrid/SendGridClient.cs
Original file line number Diff line number Diff line change
Expand Up @@ -291,10 +291,10 @@ public async Task<Response> RequestAsync(
}

/// <summary>
/// Make a request to send an email through SendGrid asychronously.
/// Make a request to send an email through SendGrid asynchronously.
/// </summary>
/// <param name="msg">A SendGridMessage object with the details for the request.</param>
/// <param name="cancellationToken">Cancel the asychronous call.</param>
/// <param name="cancellationToken">Cancel the asynchronous call.</param>
/// <returns>A Response object.</returns>
public async Task<Response> SendEmailAsync(SendGridMessage msg, CancellationToken cancellationToken = default(CancellationToken))
{
Expand All @@ -317,7 +317,7 @@ private string BuildUrl(string urlPath, string queryParams = null)
{
string url = null;

// create urlPAth - from parameter if overriden on call or from ctor parameter
// create urlPAth - from parameter if overridden on call or from ctor parameter
var urlpath = urlPath ?? UrlPath;

if (Version != null)
Expand Down