Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial dockerfile #557

Merged
merged 3 commits into from
Oct 31, 2017
Merged

Conversation

georgevanburgh
Copy link
Contributor

Basic Dockerfile, based on the dotnet:1.0-sdk image - containing the latest version of sendgrid-csharp, as well as a running instance of prism.

Closes #535.

Contains latest sources, dotnet core SDK, and running instance of prism
@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 12, 2017
@SendGridDX
Copy link

SendGridDX commented Oct 12, 2017

CLA assistant check
All committers have signed the CLA.

@thinkingserious thinkingserious added difficulty: hard fix is hard in difficulty hacktoberfest labels Oct 12, 2017
@thinkingserious
Copy link
Contributor

Hi @FireEater64,

Do you mind taking a minute to sign our CLA? It's just a quick online form.

Thanks!

With Best Regards,

Elmer

@georgevanburgh
Copy link
Contributor Author

@thinkingserious of course - should be done 😄

# Info

This Docker image contains
- `sendgrid-csharp`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's what I tried:

$ git pull https://github.com/FireEater64/sendgrid-csharp.git initial-dockerfile
$ git remote add upstream https://github.com/sendgrid/sendgrid-csharp.git
$ git merge upstream master
$ git fetch
$ docker run -it -v /Users/mbernier/Sites/branches/FireEater64:/mnt/sendgrid-csharp sendgrid/sendgrid-csharp

The error I got:

Unable to find image 'sendgrid/sendgrid-csharp:latest' locally
docker: Error response from daemon: pull access denied for sendgrid/sendgrid-csharp, repository does not exist or may require 'docker login'.

I also tried:

$ docker run -it sendgrid/sendgrid-csharp

and got a similar error:

Unable to find image 'sendgrid/sendgrid-csharp:latest' locally
docker: Error response from daemon: pull access denied for sendgrid/sendgrid-csharp, repository does not exist or may require 'docker login'

Do you know what I did incorrectly?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FireEater64 Can you please give this a look?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @mbernier - I wrote these instructions under the assumption that someone @sendgrid would build and push this container to the docker hub. Since I'm not a member of the sendgrid org, I can't do it myself, at least not under that name.

I can rework the instructions if you'd like - but to build the container yourself, just check out the branch and run docker build -t sendgrid/sendgrid-csharp . Then the instructions you mentioned above should work 😄

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, gotcha! Yes, we will eventually get this into docker hub. Until then, we want to make sure that people can run it from the library.

When we add it to docker hub we will update the docs accordingly!!
Can you please make the suggested change? Then we will get this merged.

Thank you!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course - should be done 👍

Can be removed once container has been pushed to Docker hub
@mbernier
Copy link
Contributor

Thank you so much!!

@mbernier mbernier merged commit 0acd89d into sendgrid:master Oct 31, 2017
@thinkingserious
Copy link
Contributor

Hello @FireEater64,

Thanks again for the PR!

We want to show our appreciation by sending you some swag. Could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@georgevanburgh georgevanburgh deleted the initial-dockerfile branch November 3, 2017 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: hard fix is hard in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants