-
Notifications
You must be signed in to change notification settings - Fork 587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial dockerfile #557
Initial dockerfile #557
Conversation
Contains latest sources, dotnet core SDK, and running instance of prism
Hi @FireEater64, Do you mind taking a minute to sign our CLA? It's just a quick online form. Thanks! With Best Regards, Elmer |
@thinkingserious of course - should be done 😄 |
…into initial-dockerfile
# Info | ||
|
||
This Docker image contains | ||
- `sendgrid-csharp` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's what I tried:
$ git pull https://github.com/FireEater64/sendgrid-csharp.git initial-dockerfile
$ git remote add upstream https://github.com/sendgrid/sendgrid-csharp.git
$ git merge upstream master
$ git fetch
$ docker run -it -v /Users/mbernier/Sites/branches/FireEater64:/mnt/sendgrid-csharp sendgrid/sendgrid-csharp
The error I got:
Unable to find image 'sendgrid/sendgrid-csharp:latest' locally
docker: Error response from daemon: pull access denied for sendgrid/sendgrid-csharp, repository does not exist or may require 'docker login'.
I also tried:
$ docker run -it sendgrid/sendgrid-csharp
and got a similar error:
Unable to find image 'sendgrid/sendgrid-csharp:latest' locally
docker: Error response from daemon: pull access denied for sendgrid/sendgrid-csharp, repository does not exist or may require 'docker login'
Do you know what I did incorrectly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@FireEater64 Can you please give this a look?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @mbernier - I wrote these instructions under the assumption that someone @sendgrid would build and push this container to the docker hub. Since I'm not a member of the sendgrid org, I can't do it myself, at least not under that name.
I can rework the instructions if you'd like - but to build the container yourself, just check out the branch and run docker build -t sendgrid/sendgrid-csharp .
Then the instructions you mentioned above should work 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh, gotcha! Yes, we will eventually get this into docker hub. Until then, we want to make sure that people can run it from the library.
When we add it to docker hub we will update the docs accordingly!!
Can you please make the suggested change? Then we will get this merged.
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Of course - should be done 👍
Can be removed once container has been pushed to Docker hub
Thank you so much!! |
Hello @FireEater64, |
Basic Dockerfile, based on the
dotnet:1.0-sdk
image - containing the latest version of sendgrid-csharp, as well as a running instance of prism.Closes #535.