don't require any version of ruby b/c the gem doesn't actually care #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please see my comments in the other issue. The signed CLA would cover this contribution also. Thanks! |
thinkingserious
added
type: community enhancement
|
Working on it, thanks |
|
I think we should merge this down first so that we can get all the tests to pass in sendgrid-ruby without having to modify the Gemfile or the spec |
|
@thinkingserious does someone else handle the merge of these? |
thinkingserious
added a commit
that referenced
this pull request
Jul 12, 2016
|
Not currently. |
|
oh okay, I was just wondering if you were waiting on me to merge them or something. Sorry to bother! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was able to run all the tests on ruby 2.1 which is the earliest supported version of ruby without issue. The unnecessary ruby 2.2 requirement is significantly hampering our ability to adopt usage of the SendGrid API v.3.
Also see this issue that I've opened on sendgrid-ruby which is a roadblock to me running the tests for a similar change on sendgrid-ruby: sendgrid/sendgrid-ruby#71