Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add first-timers.md for newcomers #116

Merged
merged 1 commit into from
Aug 10, 2020
Merged

docs: Add first-timers.md for newcomers #116

merged 1 commit into from
Aug 10, 2020

Conversation

daniloff200
Copy link
Contributor

Closes #112

Fixes

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

This PR adds a First Timers.MD with a guideline for newcomers

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 11, 2018
@SendGridDX
Copy link

SendGridDX commented Oct 11, 2018

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Oct 11, 2018

Codecov Report

Merging #116 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #116   +/-   ##
======================================
  Coverage    84.7%   84.7%           
======================================
  Files           3       3           
  Lines         170     170           
======================================
  Hits          144     144           
  Misses         26      26

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e7dc81...ac6932c. Read the comment docs.

@devchas devchas added difficulty: medium fix is medium in difficulty hacktoberfest status: work in progress Twilio or the community is in the process of implementing type: docs update documentation change not affecting the code labels Oct 17, 2018
@daniloff200
Copy link
Contributor Author

Hey @thinkingserious ! Are you able and have time to review and merge this PR ?

@thinkingserious thinkingserious added status: hacktoberfest approved and removed status: work in progress Twilio or the community is in the process of implementing labels Oct 21, 2018
@thinkingserious
Copy link
Contributor

Hello @daniloff200,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@daniloff200
Copy link
Contributor Author

hey @thinkingserious !
That's more than 1 year after last comment here :)

Can this PR be merged sometime?

@childish-sambino childish-sambino removed the type: docs update documentation change not affecting the code label Jul 20, 2020
@thinkingserious thinkingserious changed the base branch from master to main July 28, 2020 14:38
@childish-sambino childish-sambino changed the title Add first-timers.md for newcomers docs: Add first-timers.md for newcomers Aug 10, 2020
@childish-sambino childish-sambino merged commit 6e17aac into sendgrid:main Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: medium fix is medium in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create first time contributor documentation
5 participants