Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop using insecure option by default #81

Closed
SamMousa opened this issue Nov 18, 2017 · 1 comment
Closed

Stop using insecure option by default #81

SamMousa opened this issue Nov 18, 2017 · 1 comment
Labels
difficulty: easy fix is easy in difficulty status: work in progress Twilio or the community is in the process of implementing type: security known security issue

Comments

@SamMousa
Copy link

Issue Summary

...
CURLOPT_SSL_VERIFYPEER => false
...

Steps to Reproduce

  1. Install the library.
  2. Use it.
  3. Get a MITM attacker
  4. Don't notice it because we're not validating SSL certificates

Technical details:

  • php-http-client Version: master
  • PHP Version: 7.1

Why would you disable SSL peer verification by default in a library??
At the very least people incapable of configuring their servers decently should disable security options manually. Current it's the other way around and only people randomly inspecting source code notice that you're disabling SSL security features by default...
@thinkingserious thinkingserious added status: help wanted requesting help from the community type: community enhancement feature request not on Twilio's roadmap labels Nov 28, 2017
@thinkingserious
Copy link
Contributor

Thanks for catching this @SamMousa!

I've added this to our backlog for a fix.

To those who would like to make a PR, the fix would happen here.

With Best Regards,

Elmer

@thinkingserious thinkingserious added difficulty: easy fix is easy in difficulty up-for-grabs type: security known security issue labels Feb 28, 2018
thinkingserious added a commit that referenced this issue Mar 8, 2018
@thinkingserious
Fix #81: Stop using insecure option by default
a57b6e2
@thinkingserious thinkingserious mentioned this issue Mar 8, 2018
Merged
@thinkingserious thinkingserious added status: work in progress Twilio or the community is in the process of implementing and removed help wanted status: help wanted requesting help from the community type: community enhancement feature request not on Twilio's roadmap labels Mar 8, 2018
thinkingserious added a commit that referenced this issue Mar 8, 2018
@thinkingserious
Merge pull request #87 from sendgrid/81_insecure
7f886cb 
Fix #81: Stop using insecure option by default
@thinkingserious thinkingserious mentioned this issue Mar 10, 2018
Closed
Falseclock pushed a commit to Falseclock/php-http-client that referenced this issue Jan 30, 2019
@thinkingserious
Fix sendgrid#81: Stop using insecure option by default
624562a
Falseclock pushed a commit to Falseclock/php-http-client that referenced this issue Jan 30, 2019
@thinkingserious
Merge pull request sendgrid#87 from sendgrid/81_insecure
599c037 
Fix sendgrid#81: Stop using insecure option by default
@thinkingserious thinkingserious mentioned this issue May 7, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty: easy fix is easy in difficulty status: work in progress Twilio or the community is in the process of implementing type: security known security issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thinkingserious @SamMousa