refactor code #107

[themousepotato]

Checklist

• I have made a material change to the repo (functionality, testing, spelling, grammar)
• I have read the [Contribution Guide] and my PR follows them.
• I updated my branch with the master branch.
• I have added tests that prove my fix is effective or that my feature works
• I have added necessary documentation about the functionality in the appropriate .md file
• I have added in line documentation to the code I modified

Short description of what this PR does:

• Try to fix Fix "method_complexity" issue in package_managers.py #107

If you have questions, please send an email to SendGrid, or file a GitHub Issue in this repository.

[SendGridDX]

All committers have signed the CLA.

[themousepotato]

@thinkingserious Why isn't the build successful? How can I set the environment variables? I haven't found any documentation for this.

[42B]

This PR doesn't make sense and the changes seem superfluous at best. These chained if statements do not need to be broken up into two nested if statements each. Python already short-circuits and will not even evaluate the second check if the first one fails in cases like this using and.

[themousepotato]

@42B Oh my bad! Any tips to handle this?

…

On Sunday, October 28, 2018, 42B ***@***.***> wrote: ***@***.**** commented on this pull request. This PR doesn't make sense and the changes seem superfluous at best. These chained if statements do not need to be broken up into two nested if statements each. Python already short-circuits and will not even evaluate the second check if the first one fails in cases like this using and. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#161 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AgXlPkfrIrUr72ATG1XEfd0drkxMJKOrks5upQXXgaJpZM4X8R29> .

[42B]

@themousepotato

I'm not from sendgrid so I would defer to them as to whether they find this PR useful or not. I'm having trouble seeing how this PR would reduce complexity mentioned in #107 or add any real benefit to the repo but those decisions are not up to me. All you did was break chained if statements into two separate if statements each but you didn't reduce the total number of if statements at all?

Maybe you could give a detailed description on exactly how this PR reduces the complexity score from codeclimate? After that, if the previous score was 27 and the maximum should be 5, what is the new complexity score after your changes were made?

• https://docs.codeclimate.com/v1.0/docs/cognitive-complexity