Skip to content
This repository has been archived by the owner on Aug 28, 2020. It is now read-only.

Test for checking files in repo #108

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

parth-p
Copy link

@parth-p parth-p commented Oct 30, 2017

Fixes #99
Closes #99
-->

Fixes

Added new test file for requirements

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

@SendGridDX
Copy link

SendGridDX commented Oct 30, 2017

CLA assistant check
All committers have signed the CLA.

@thinkingserious
Copy link
Contributor

@parth-p

We have not been able to merge your Pull Request, but because you are awesome - we wanted to make sure you could still get a SendGrid Hacktoberfest shirt.

Please go fill out our swag form before Nov 5th and we will send the shirt! (We know that you might have tried this before and it didn’t work, sorry about that!)

You have till Nov 5th to fill out this form in order to get the Hacktoberfest shirt!

Thank you for contributing during Hacktoberfest! We hope to see you in the repos soon! Just so you know, we always give away a SendGrid shirt for your first ever non-Hacktoberfest PR that gets merged.

@parth-p
Copy link
Author

parth-p commented Jan 18, 2018 via email

@thinkingserious
Copy link
Contributor

Hello @parth-p,

You are on the list to receive swag, unfortunately shipments to India are taking longer than expected, but should arrive by the end of the month.

Thanks for checking in!

With Best Regards,

Elmer

Copy link

@42B 42B left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


# ./Docker or docker/Docker
def test_docker_dir(self):
self.assertEqual(True, os.path.isdir("./Dockerfile"))
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self.assertTrue(...) ?


# ./docker-compose.yml or ./docker/docker-compose.yml
def test_docker_compose(self):
self.assertEqual(True, os.path.isfile('docker-compose.yml'))
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self.assertTrue(...) ?


# ./.env_sample
def test_env(self):
self.assertEqual(True, os.path.isfile('./env_sample'))
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self.assertTrue(...) ?


# ./.gitignore
def test_gitignore(self):
self.assertEqual(True, os.path.isfile('./.gitignore'))
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self.assertTrue(...) ?


# ./.travis.yml
def test_travis(self):
self.assertEqual(True, os.path.isfile('./.travis.yml'))
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self.assertTrue(...) ?


# ./README.md
def test_readme(self):
self.assertEqual(True, os.path.isfile('./README.md'))
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self.assertTrue(...) ?


# ./TROUBLESHOOTING.md
def test_troubleshooting(self):
self.assertEqual(True, os.path.isfile('./TROUBLESHOOTING.md'))
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self.assertTrue(...) ?


# ./USAGE.md
def test_usage(self):
self.assertEqual(True, os.path.isfile('./USAGE.md'))
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self.assertTrue(...) ?


# ./USE_CASES.md
def test_use_cases(self):
self.assertEqual(True, os.path.isfile('./USE_CASES.md'))
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self.assertTrue(...) ?

self.assertEqual(True, os.path.isfile('./USE_CASES.md'))

if __name__ == '__main__':
unittest.main()
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing 4 spaces of indentation

>>> import unittest
... 
... if __name__ == '__main__':
... unittest.main()
  File "<input>", line 4
    unittest.main()
           ^
IndentationError: expected an indented block

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add unittest to check for specific repo files
5 participants