fix: do not disconnect and connect when the accessToken is changed #969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bang9 oh, wow! thank you so much!! let me check it out and resolve it |
liamcho
reviewed
Feb 14, 2024
There was a problem hiding this comment.
Has this fix been tested/verified?
When SDK fails at session key refresh with below error
err.isSessionTokenExpiredError || err.code === SendbirdErrorCode.APPLICATION_NOT_FOUND
SDK awaits customer callback onSessionTokenRequired response to receive new auth token from customer. However, UIKit does not handle this automatically. Im not sure this is related to removing accessToekn dependency here but customer needs to handle onSessionTokenRequired outside UIKit in their own app. Am I understanding corrrecty?
|
synced offline with above question. There is no problem since UIKit opens |
Merged
bang9
added a commit
that referenced
this pull request
Feb 20, 2024
## [v3.12.0] (Feb 16, 2024)
### Features:
* Local cache is enabled by default
* If desired, it can be disabled using sdkInitParams
```tsx
import SendbirdProvider from '@sendbird/uikit-react/SendbirdProvider';
const App = () => (
<SendbirdProvider
// ...
sdkInitParams={{ localCacheEnabled: false }}
/>
)
```
* Added `GroupChannel` and `GroupChannelList` modules.
* With the introduction of `GroupChannel` and `GroupChannelList`, a new
local caching feature has been added, allowing you to experience a more
efficient chat environment.
We provide a massive component called `App` that combines all the
features. From now on, this component will use `GroupChannel` and
`GroupChannelList` instead of `Channel` and `ChannelList`.
If you wish to continue using `Channel` and `ChannelList`, you can use
`enableLegacyChannelModules` to ensure the previous components are still
available for use.
```tsx
import SendbirdApp from '@sendbird/uikit-react/App';
const App = () => (
<SendbirdApp
// ...
enableLegacyChannelModules
/>
);
```
* You can find detailed changes, usage instructions, and migration
methods in the document here: [Migration
Guide](https://github.com/sendbird/sendbird-uikit-react/blob/main/MIGRATION_COLLECTION.md)
### Fixes:
* Fixed a bug where the session refresh failed when the `accessToken`
was changed
[#969](#969)
* Fixed a bug causing infinite loading when the channel is not selected
in the Channel module
[#970](#970)
* Fixed a bug where the mention feature was not functioning properly
[#971](#971)
* Fixed a bug where URLs with numbered top-level domains were treated as
links [#972](#972)
* Fixed a bug where message scroll delays were inconsistently applied
[#975](#975)
* Fixed a bug where `isUserIdUsedForNickname` was not functioning
properly
[#976](#976)
* Optimized the rendering of `SendbirdProvider`
* Optimized the SDK initialization logic for StrictMode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
accessTokenis changed,disconnectandconnectare called again.accessToken, the session_key refresh performed by the SDK is canceled(API request cancel) due to thedisconnecttriggered in (1).accessTokenhas already expired, it is refreshed by the SDK(SessionHandler). Therefore, UIKit does not need to rely on this value to handle the connect logic.ticket: CLNP-2257