Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug-fix: Fixed a bug where channel is being removed from my channel list when other member leaves the channel #947

Conversation

liamcho
Copy link
Contributor

@liamcho liamcho commented Jan 29, 2024

Fixes: CLNP-2121

Original PR

Changelogs

  • Fixed a bug where channel is being removed from my channel list when other member leaves the channel
  • Fixed a bug where channel avatar image is not updated when a member leaves, or joins, or profileUrl changes

After fix

Note the video displays first fix only.

video2908626998.mp4

Co-authored-by: @aldenquimby

@liamcho liamcho self-assigned this Jan 29, 2024
@liamcho liamcho requested a review from HoonBaek January 29, 2024 08:04
Copy link
Contributor

@HoonBaek HoonBaek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, however, pls fix the lint before merge :D
I removed the spaces in the comment;;

@liamcho liamcho merged commit 1acba7f into main Jan 29, 2024
4 checks passed
@liamcho liamcho deleted the bug-fix/v3/fix-bug-where-channel-removed-from-my-channel-list-when-other-member-leaves branch January 29, 2024 08:17
@liamcho liamcho added v3.11.0 and removed v3.10.2 labels Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants