fix: channel view should show NO_CHANNEL placeholder after leaving all channels #901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @AhyoungRyu ! |
bang9
approved these changes
Dec 29, 2023
Merged
HoonBaek
added a commit
that referenced
this pull request
Jan 5, 2024
## [v3.9.3] (Jan 5, 2024) ### Fixes: * **Refactor `--sendbird-vh` CSS Variable Logic in InviteUsers Component** - Improved code readability by moving logic to the `InviteUsers` component. - [GitHub PR #899](#899) (CLNP-1806) * **Prevent Access to `window` in SSR Environments** - Fixed server-side rendering issues in NextJS by preventing access to the `window` object. - (Original Author: [Aaron James King](https://github.com/AaronJamesKing)) - [GitHub PR #900](#900) (SBISSUE-14287) * **Update Channel View to Show `NO_CHANNEL` Placeholder** - Channel view now displays `NO_CHANNEL` placeholder after leaving all channels. - (Original Author: [Alden Quimby](https://github.com/aldenquimby)) - [GitHub PR #901](#901) * **Fix Replay of Voice Memos** - Resolved the issue preventing the replay of voice memos. - (Original Author: [Alden Quimby](https://github.com/aldenquimby)) - [GitHub PR #902](#902) * **Resolve Image Upsizing Issue in ImageCompression** - Fixed the issue with image upsizing in ImageCompression. (Original Author: [GitHub User](https://github.com/GitHubUser)) (CLNP-1832) - [GitHub PR #903](#903) * **Update Peer Dependencies for npm Install** - Addressed peer dependencies issues in npm install. (Original Author: [GitHub User](https://github.com/GitHubUser)) - [GitHub PR #905](#905) * **Fix Scroll Behavior in Open Channel** - Fixed scroll behavior when sending a message in an open channel. (Original Author: [GitHub User](https://github.com/GitHubUser)) - [GitHub PR #906](#906) * **Fix Cross-Site Scripting Vulnerability in OGTag** - Fixed cross-site scripting vulnerability in OGTag. (Original Author: [GitHub User](https://github.com/GitHubUser)) - [GitHub PR #907](#907)
|
@AhyoungRyu @bang9 FYI I believe this caused an issue with the mobile layout in the default App: sendbird-uikit-react/src/modules/App/MobileLayout.tsx Lines 109 to 112 in 0f8fc3a I think this needs to change to: onChannelSelect={(channel) => {
setCurrentChannel(channel);
if (channel) {
setPanel(PANELS.ChannelPanel);
}
}}So that you only switch to the channel panel if a channel was actually selected (vs unselected / left) Apologies for not catching this in my initial PR |
|
@AhyoungRyu @bang9 another possibly related bug here (although it looks to me like it may have been a problem beforehand too): #937 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change comes from #894 and made by @aldenquimby