Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated the langchain tools #65

Closed

Conversation

shubhiscoding
Copy link

Updated every class under langchain to implement Action interface without changing it's functionalities.
This pull request was created for https://app.gib.work/bounties/1a071256-33aa-4369-8d24-21839bcd4192 in an attempt to solve a bounty #53 . Payment for the bounty is immediately sent to the contributor after merge.

@thearyanag
Copy link
Member

hey @shubhiscoding - awesome work just 1 thing will need to change

the action for each tool needs to be independent, so can be in a file under src/action/index.ts

and then import those action in src/langchain/index.ts and use them there, as per the orignal tool without extending it to Action interface

@thearyanag thearyanag mentioned this pull request Dec 26, 2024
4 tasks
@thearyanag
Copy link
Member

for validator, you'll need to use zod

@shubhiscoding
Copy link
Author

shubhiscoding commented Dec 28, 2024

Hii @thearyanag I have made the changes you asked for and tested it too, might be the fix for #53 Please review it once!
Screenshot from 2024-12-28 17-12-45

@shubhiscoding
Copy link
Author

@thearyanag are there any changes to be made?

@PurpleSquirrelMedia
Copy link

I reviewed your test, I think this can be submitted for a PR.

@shubhiscoding
Copy link
Author

I reviewed your test, I think this can be submitted for a PR.

Can it be merged then? @thearyanag?

@thearyanag
Copy link
Member

hey @shubhiscoding - this looks good

  • it's not working for single input functions
  • what's the use of validator if you are not using it anywhere?
  • you have defined types from Eliza repo, but those are not used anywhere in the kit

@thearyanag
Copy link
Member

closing this in favour of #72

@thearyanag thearyanag closed this Dec 30, 2024
@shubhiscoding
Copy link
Author

Hii @thearyanag I have fixed the single input function issue, also removed all the unsed types and have added input vallidation in the lastest commit I just pushed, can you please reopen this?
Screenshot from 2024-12-30 08-14-08

@shubhiscoding shubhiscoding mentioned this pull request Dec 30, 2024
4 tasks
@shubhiscoding
Copy link
Author

I'm raising another PR #101 just review it once, If it doesn't fixes the issue close it and I won't raise a PR again for this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants