Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SENP-531] feat(ci): add actionlint check #79

Merged
merged 2 commits into from
Mar 21, 2024
Merged

Conversation

jdassonvil
Copy link
Contributor

@jdassonvil jdassonvil commented Mar 19, 2024

@jdassonvil jdassonvil requested a review from a team as a code owner March 19, 2024 14:21
@jdassonvil jdassonvil changed the title feat(ci): add actionlint check [SENP-531] feat(ci): add actionlint check Mar 19, 2024
Copy link

@jdassonvil jdassonvil force-pushed the jerome/add-actionlint branch from fbde1b0 to 245850a Compare March 19, 2024 14:23
@jdassonvil jdassonvil force-pushed the jerome/add-actionlint branch from 245850a to 6a4c623 Compare March 20, 2024 14:41
"owner": "actionlint",
"pattern": [
{
"regexp": "^(?:\\x1b\\[\\d+m)?(.+?)(?:\\x1b\\[\\d+m)*:(?:\\x1b\\[\\d+m)*(\\d+)(?:\\x1b\\[\\d+m)*:(?:\\x1b\\[\\d+m)*(\\d+)(?:\\x1b\\[\\d+m)*: (?:\\x1b\\[\\d+m)*(.+?)(?:\\x1b\\[\\d+m)* \\[(.+?)\\]$",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am probably missing context but what is this regex from hell used for ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really wish we could add comments to JSON for these cases 😓

@jdassonvil jdassonvil merged commit 70c0b2b into master Mar 21, 2024
1 check passed
@jdassonvil jdassonvil deleted the jerome/add-actionlint branch March 21, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants