chore(docker-tag): do not fail if tag already exists #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
floriantz
commented
Oct 21, 2024
| @@ -70,5 +70,10 @@ jobs: | |||
|
|
|||
| - name: Tag image | |||
| run: | | |||
| MANIFEST=$(aws ecr batch-get-image --repository-name ${{ inputs.image_name }} --image-ids imageTag=${{ inputs.image_tag_from }} --output text --query 'images[].imageManifest') | |||
| aws ecr put-image --repository-name ${{ inputs.image_name }} --image-tag ${{ inputs.image_tag_to}} --image-manifest "$MANIFEST" | |||
| IMAGE_EXISTS=$(aws ecr describe-images --repository-name ${{ inputs.image_name }} --image-ids imageTag=${{ inputs.image_tag_to }} 2>/dev/null) | |||
There was a problem hiding this comment.
The only addition to the initial PR is the 2>/dev/null
jdassonvil
approved these changes
Oct 21, 2024
floriantz
added a commit
that referenced
this pull request
Oct 21, 2024
This reverts commit 1eee321.
floriantz
added a commit
that referenced
this pull request
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as the previous PR but with an addition to better handle the error. I had a bit of a different behaviour when testing it locally and didn't have it crashing but piping the error to
/dev/nullshould fix it hopefully.