Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.4: Fix 'Implicitly marking parameter as nullable is deprecated' #124

Merged
merged 1 commit into from
Nov 24, 2024

Conversation

jay-knight
Copy link
Contributor

@jay-knight jay-knight commented Nov 23, 2024

In PHP 8.4, implicitly nullable function parameters are deprecated. This change makes those explicitly nullable by prepending a ? so that the tests pass with no deprecation warnings.

@senaranya senaranya self-assigned this Nov 24, 2024
@senaranya senaranya merged commit 19b2fdc into senaranya:master Nov 24, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants