ci: install soldeer in release workflow
#867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* chore: trigger release workflow * chore: format * ci: set `soldeer` credentials in github workspace * chore: remove commentouts * chore: add back tag trigger
sripwoud
commented
Oct 22, 2024
| @@ -37,6 +47,7 @@ jobs: | |||
| run: yarn version:publish | |||
| env: | |||
| NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }} | |||
| SOLDEER_LOGIN_FILE: ${{ github.workspace }}/soldeer_login | |||
There was a problem hiding this comment.
use of this env var undocumented in the soldeer readme.
I found it in the source code directly
https://github.com/mario-eth/soldeer/blob/c3d70821ed7ef7a3d9264a6872139446c48cac5a/crates/core/src/utils.rs#L62
cedoor
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
soldeercli setup in release workflow.soldeer pushneeds an authentication token.However https://soldeer.xyz does not allow for creating api tokens or create teams.
So I had to retrieve the token generated with a personal account locally.
Token was retrieved with:
I added the content of this
.soldeer_loginfile to theSOLDEER_TOKENrepo secret.Once we have a shared mail address for the semaphore team. We should update the email address and token tied to the
semaphore-protocol-contractssoldeer project.Test
See this comment in branch used for testing