Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Semaphore Identity example code bug fix (Fix #848) #849

Merged
merged 2 commits into from
Aug 12, 2024

Conversation

csiejimmyliu
Copy link
Contributor

@csiejimmyliu csiejimmyliu commented Aug 12, 2024

Description

I deleted the undeclared input "signature" parameter in the signMessage function.

Issue

Closes #848

Copy link
Member

@vplasencia vplasencia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much @csiejimmyliu

packages/identity/README.md Outdated Show resolved Hide resolved
@csiejimmyliu
Copy link
Contributor Author

Hey @vplasencia
It says Merging is blocked(The base branch requires all commits to be signed.)
I follow some instructions, but I can only sign the newest commit.
Could you tell me how I can sign previous commits?
(BTW this is my first pull request XD)

@vplasencia
Copy link
Member

Hey @csiejimmyliu no worries. It's fine. Great work 🚀

@vplasencia vplasencia merged commit 5ef73e2 into semaphore-protocol:main Aug 12, 2024
5 checks passed
Copy link

gitpoap-bot bot commented Aug 12, 2024

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2024 Semaphore Contributor:

GitPOAP: 2024 Semaphore Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The sample code has bug(# Identity.verifySignature)
3 participants