chore: publish contracts to soldeer #820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: publish contracts to soldeer
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
sripwoud
commented
Jul 8, 2024
package.json
Outdated
| @@ -21,8 +21,8 @@ | |||
| "format": "prettier -c . && yarn workspace semaphore-docs format", | |||
| "format:write": "prettier -w . && yarn workspace semaphore-docs format:write", | |||
| "docs": "typedoc", | |||
| "version:bump": "yarn workspaces foreach -A --no-private version -d ${0} && yarn version apply --all && yarn remove:stable-version-field && NO_HOOK=1 git commit -am \"chore: v${0}\" && git tag v${0}", | |||
| "version:publish": "yarn build:libraries && yarn clean:cli-templates && yarn workspaces foreach -A --no-private npm publish --tolerate-republish --access public", | |||
| "version:bump": "ts-node scripts/version.ts ${0}", | |||
There was a problem hiding this comment.
no directly related to this PR, but given the length of this command, I suggest extracting it in its own script definition file to improve readability
sripwoud
commented
Jul 8, 2024
package.json
Outdated
| "version:bump": "yarn workspaces foreach -A --no-private version -d ${0} && yarn version apply --all && yarn remove:stable-version-field && NO_HOOK=1 git commit -am \"chore: v${0}\" && git tag v${0}", | ||
| "version:publish": "yarn build:libraries && yarn clean:cli-templates && yarn workspaces foreach -A --no-private npm publish --tolerate-republish --access public", | ||
| "version:bump": "ts-node scripts/version.ts ${0}", | ||
| "version:publish": "ts-node scripts/publish.ts", |
There was a problem hiding this comment.
this one we need to change to add the soldeer stuff.
As it gets more complicated, better to make a dedicated script file here too
sripwoud
commented
Jul 8, 2024
| async function maybePushToSoldeer() { | ||
| // api not documented, may change, found by inspecting the network tab | ||
| const response = await fetch( | ||
| "https://api.soldeer.xyz/api/v1/revision?project_name=semaphore-protocol-contracts&limit=1" |
There was a problem hiding this comment.
I suggest semaphore-protocol-contracts as pkg name on soldeer. soldeer does not support orgs.
There was a problem hiding this comment.
What about semaphore-contracts? Sounds easier to remember
sripwoud
commented
Jul 8, 2024
| const { data, status } = await response.json() | ||
|
|
||
| // fail status is no version published at all yet | ||
| if (status === "fail" || compare(contractsLocalVersion, data[0].version) === 1) |
There was a problem hiding this comment.
status will be fail only for the first run (no pkg in soldeer db yet)
sripwoud
commented
Jul 8, 2024
scripts/publish.ts
Outdated
Comment on lines
18
to
19
| "soldeer", | ||
| ["push", `semaphore-protocol-contracts~${contractsLocalVersion}`, "packages/contracts/contracts"], |
There was a problem hiding this comment.
sripwoud
added
feature 🚀
sripwoud
commented
Jul 8, 2024
cedoor
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #800
Publish semaphore contracts to https://soldeer.xyz as
semaphore-protocol-contractsin addition to publishing to npm as@semaphore-protocol/contracts.