-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Security alert on install from ethers, ws #920
Labels
bug 🐛
Something isn't working
Comments
Would it also be valuable to add checks either in CI or a yarn command/script that fails if it detects a |
jacque006
added a commit
to jacque006/semaphore
that referenced
this issue
Dec 11, 2024
Update ethers version to resolve ws security issue (CVE-2024-37890). Move contract address check outside of branch statement so Typescript can see. Add build instructions to setup to resolve 'Cannot find module '@semaphore-protocol/...' when running tests for the first time. re semaphore-protocol#920
Yes, I think it's definitely valuable! Do you want to open another issue for it? |
cedoor
pushed a commit
that referenced
this issue
Dec 12, 2024
Update ethers version to resolve ws security issue (CVE-2024-37890). Move contract address check outside of branch statement so Typescript can see. Add build instructions to setup to resolve 'Cannot find module '@semaphore-protocol/...' when running tests for the first time. re #920
Thanks @jacque006 🙏🏽 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
When installing the latest
@semaphore-protocol/core
(v4.7.2
) & runningnpm audit
, the following alert appears:To Reproduce
npm install @semaphore-protocol/core
(Note some older versions may have this alert as well)npm audit
Expected behavior
No security alert is present. This has been fixed in
ethers >= v6.13.1
https://github.com/ethers-io/ethers.js/releases/tag/v6.13.1.Note that since this is a server-side
ws
issue, it is unlikely have an impact barring some exceptional use cases (Using Semaphore's ether's ws version on server)Technologies (please complete the following information):
v20.18.1
10.8.2
Additional context
I will open PR to address by updating
ethers
version. Feel free to assign this issue to me.The text was updated successfully, but these errors were encountered: