-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: upgrade npm dependency to v8 #442
Conversation
it looks like v8 of npm dropped support for node v15, so the need for this makes sense.
since v15 is also dropped, it is technically a breaking change we are currently working through converting the project to ESM, which would also be a breaking change. along with that, we plan to raise the minimum node version to v16, which would support this npm version more naturally. i tried to look at the npm releases to see if these fixes are available in a v7 release, but it doesnt look promising from a brief look. could you confirm if this is resolvable without the v8 upgrade, if you havent already? |
There is an issue about this in the npm/cli repo: npm/cli#3785 But it doesn't look like they want to backport their changes to older versions. |
Co-authored-by: Matt Travi <[email protected]>
thanks a lot for the investigation and contribution, @AlexanderBabel! |
🎉 This PR is included in version 9.0.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 9.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This PR fixes the GHSA-896r-f27r-55mw and GHSA-93q8-gq69-wqmw vulnerabilities by updating
npm
to v8.The
npm
v8.0.0 package drops support for Node 10 and 11. These versions are no longer supported by this project. Therefore, this is not a breaking change.Additionally, I updated the
engine
section in thepackage.json
. #408 fails because of a miss match. I applied the recommendation from the workflow run https://github.com/semantic-release/npm/runs/4502004243.