fix: fix regex rules evaluation

semantic-release · Jan 21, 2018 · 53faf3b · 53faf3b
1 parent 67f9f88
commit 53faf3b
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 5 deletions.
diff --git a/lib/analyze-commit.js b/lib/analyze-commit.js
@@ -21,7 +21,7 @@ module.exports = (releaseRules, commit) => {
           commit,
           omit(rule, ['release', 'breaking']),
           (obj, src) =>
-            /^\/.*\/$/.test(src) || isRegExp(src) ? new RegExp(/^\/.*\/$/.exec(src)[1]).test(obj) : undefined
+            /^\/.*\/$/.test(src) || isRegExp(src) ? new RegExp(/^\/(.*)\/$/.exec(src)[1]).test(obj) : undefined
         )
     )
     .every(match => {

diff --git a/test/analyze-commit.test.js b/test/analyze-commit.test.js
@@ -46,15 +46,21 @@ test('Return undefined if there is no match', t => {
 });
 
 test('Match with regex', t => {
-  const commit = {type: 'docs', scope: 'README'};
+  const rules = [{type: 'docs', scope: /test\(.*\)/, release: 'minor'}];
+  const match = {type: 'docs', scope: 'test(readme): message'};
+  const notMatch = {type: 'docs', scope: 'test2(readme): message'};
 
-  t.is(analyzeCommit([{type: 'docs', scope: /RE..ME/, release: 'minor'}], commit), 'minor');
+  t.is(analyzeCommit(rules, match), 'minor');
+  t.is(analyzeCommit(rules, notMatch), undefined);
 });
 
 test('Match with regex as string', t => {
-  const commit = {type: 'docs', scope: 'README'};
+  const rules = [{type: 'docs', scope: '/test\\(.*\\)/', release: 'minor'}];
+  const match = {type: 'docs', scope: 'test(readme): message'};
+  const notMatch = {type: 'docs', scope: 'test2(readme): message'};
 
-  t.is(analyzeCommit([{type: 'docs', scope: '/RE..ME/', release: 'minor'}], commit), 'minor');
+  t.is(analyzeCommit(rules, match), 'minor');
+  t.is(analyzeCommit(rules, notMatch), undefined);
 });
 
 test('Return highest release type if multiple rules match', t => {