-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
initial work adding asset version back so cache busts #1
base: 3.x
Are you sure you want to change the base?
Conversation
@kilgore5 just looking to confirm, does this work for your coffescript/js assets too? i'm not seeing this working on our javascript files and can't see why 😕 |
i do see there are very different processor files for coffeescript and sass (primarily the use of |
@jacobbednarz since we ended up using a monkey-patch (basically the same code) I haven't used this specific patch code in a long time. But I can confirm that the monkey patch is working correctly for us for js assets (bumping the assets version busts the cache for all files, making changes to one coffeescript file busts the cache for the file it's compiled into and forces re-compilation of that file, etc). Is there an edge case I'm missing? |
@kilgore5 I'm really not sure at this point. It could very well be the way we're running it in our codebase but I can't be certain since I also can't pinpoint exactly what part of this isn't working to update the filename hash. |
Conclusion: Monkey Patch