Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking changes on patch update #46

Closed
madjam002 opened this issue Oct 19, 2017 · 3 comments
Closed

Breaking changes on patch update #46

madjam002 opened this issue Oct 19, 2017 · 3 comments

Comments

@madjam002
Copy link

0.9.7 was published recently which now bundles JS which is ES6 rather than ES5.
This is a breaking change and therefore should be a major version bump due to consuming projects now requiring an ES6 compliant environment.

Would it be possible to revert these changes and release a new patch, and then release the change to ES6 as a major version bump (e.g 1.0.0)?

@selfrefactor
Copy link
Owner

OK, so you want me to release 0.9.8 which will be compiled to ES5 and then switch to ES6 and publish 1.0.0

That is nice way to satisfy both words and I appreciate your input on the matter.

0.9.8 will be released within the next 24 hours

@madjam002
Copy link
Author

Yeah pretty much, that way those of us who are pulling down 0.9.x will get the ES5 version which won't break anything, and then upgrading to 1.0.0 will be ES6. To be fair I think if your major version is 0 people just tend to put breaking changes as the minor version bump, e.g 0.10.0 but personally I always increment the major version as that's following semver a bit more strictly.

Thanks for this 😃

@selfrefactor
Copy link
Owner

So 0.9.8 is published and it should be ES5 compatible. I leave the issue open so you have time to report if that is not the case. Once again, thanks for bringing this up.

optimusway added a commit to LykkeCity/LykkeTerminalWeb that referenced this issue Dec 28, 2017
ghost pushed a commit to LykkeCity/LykkeTerminalWeb that referenced this issue Mar 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants