Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#280 Stripe BillingInfo front-end form and validation (fe + be) #283

Merged
merged 4 commits into from
Dec 21, 2020

Conversation

amihaiemil
Copy link
Member

@amihaiemil amihaiemil commented Dec 19, 2020

Fixes #280

Added the front-end form and validation;
Added backend param bean and validation;
Saving BillingInfo to Stripe Customer (wallet).

@charlesmike
Copy link

@amihaiemil thank you for your Pull Request. I'll assign someone to review it soon.

@charlesmike
Copy link

@amihaiemil please review this Pull Request. Deadline (when it should be merged or closed) is 2020-12-22T18:04:55.133704.

You should check if the requirements have been implemented (partially or in full), if there are unit tests covering the changes and if the CI build passes. Feel free to reject the PR or ask for changes if it's too big or not clear enough.

Estimation here is 30 minutes, that's how much you will be paid. You will be paid even if this PR gets rejected.

@charlesmike
Copy link

@amihaiemil Don't forget to close this ticket before the deadline (2020-12-22T18:04:55). You are past the first half of the allowed period.

@amihaiemil amihaiemil marked this pull request as ready for review December 21, 2020 13:09
@amihaiemil amihaiemil merged commit a23ce53 into self-xdsd:master Dec 21, 2020
@amihaiemil amihaiemil deleted the 280 branch December 21, 2020 13:09
@charlesmike
Copy link

@amihaiemil thank you for resolving this ticket. I've just added it to your active invoice. You can always check all your invoices and more on the Contributor Dashboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Form for Legal Name and Address of Client
2 participants