Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Invoice Payment Only If totalAmount >= 108 EUR #300

Closed
amihaiemil opened this issue Dec 31, 2020 · 7 comments · Fixed by #313
Closed

Allow Invoice Payment Only If totalAmount >= 108 EUR #300

amihaiemil opened this issue Dec 31, 2020 · 7 comments · Fixed by #313
Labels

Comments

@amihaiemil
Copy link
Member

We made this change in the core, but we also have to do it on the web UI.

@charlesmike
Copy link

@criske this is your task now, please go ahead. Deadline (when this ticket should be closed) is 2021-01-10T14:11:00.183294.

Estimation here is 60 minutes, that's how much you will be paid.

Remember, you don't have to solve everything in this ticket - you can solve it partially and leave todo markers in the code, which will become future tasks.

If you have any questions don't ask me, I'm not a technical person. Open new tickets instead.

If you don't have time or simply don't want to work on this, you can always resign.

@amihaiemil amihaiemil changed the title Allow Invoice Payment Only If totalAmound >= 108 EUR Allow Invoice Payment Only If totalAmount >= 108 EUR Dec 31, 2020
@charlesmike
Copy link

@amihaiemil please keep in mind that manual assignment of tickets is a bad practice and it is discouraged. Next time, please let me elect the assignee.

@amihaiemil
Copy link
Member Author

@criske this is one of the more urgent issues. Can you fix it these days when you have some time? :D

@criske
Copy link
Contributor

criske commented Jan 4, 2021

@amihaiemil I'll fix asap :)

criske added a commit to criske/self-web that referenced this issue Jan 4, 2021
criske added a commit to criske/self-web that referenced this issue Jan 4, 2021
@charlesmike
Copy link

@criske Don't forget to close this ticket before the deadline (2021-01-10T14:11). You are past the first half of the allowed period.

criske added a commit to criske/self-web that referenced this issue Jan 5, 2021
@amihaiemil
Copy link
Member Author

paid with transaction id 8DE32677XW123643X

amihaiemil added a commit that referenced this issue Jan 5, 2021
#300 Allow Invoice Payment Only If totalAmount >= 108 EUR
@charlesmike
Copy link

@criske thank you for resolving this ticket. I've just added it to your active invoice. You can always check all your invoices and more on the Contributor Dashboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants