Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code cleanup #219

Merged
merged 20 commits into from
Feb 18, 2023
Merged

Code cleanup #219

merged 20 commits into from
Feb 18, 2023

Conversation

RameshBabuPrudhvi
Copy link
Member

@RameshBabuPrudhvi RameshBabuPrudhvi commented Feb 17, 2023 •
edited
Loading

🤔 What's changed?

  • Use in built Selenium Manager instead of WebDriver Binaries for Core module
  • Parse Excel into Map of List of Maps

⚡️ What's your motivation?

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt (improvement to code design, tooling, documentation etc. without changing behaviour)
  • 🐛 Bug fix (non-breaking change which fixes a defect)
  • ⚡ New feature (non-breaking change which adds new behaviour)
  • 💥 Breaking change (incompatible changes to the API)

♻️ Anything particular you want feedback on?

📋 Checklist:

  • I agree to respect and uphold the Selcukes Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

@RameshBabuPrudhvi RameshBabuPrudhvi changed the title Remove WebDriver Binaries Configurtion [Core] Remove WebDriver Binaries Configurtion Feb 17, 2023
@RameshBabuPrudhvi RameshBabuPrudhvi changed the title [Core] Remove WebDriver Binaries Configurtion Code cleanup Feb 18, 2023
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 2 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@RameshBabuPrudhvi RameshBabuPrudhvi merged commit e6832ed into master Feb 18, 2023
@RameshBabuPrudhvi RameshBabuPrudhvi deleted the binaries branch February 18, 2023 09:50
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@RameshBabuPrudhvi