Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Param change verification #551

Merged
merged 3 commits into from
Nov 19, 2024
Merged

Param change verification #551

merged 3 commits into from
Nov 19, 2024

Conversation

philipsu522
Copy link
Contributor

@philipsu522 philipsu522 commented Nov 12, 2024

Describe your changes and provide context

Ensure param changes are valid

Testing performed to validate your change

Unit tests, tested on local chain

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

Attention: Patch coverage is 62.50000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 54.87%. Comparing base (4214e66) to head (f6176f1).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
x/gov/keeper/proposal.go 57.14% 4 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #551   +/-   ##
=======================================
  Coverage   54.87%   54.87%           
=======================================
  Files         631      631           
  Lines       54926    54941   +15     
=======================================
+ Hits        30138    30148   +10     
- Misses      22633    22636    +3     
- Partials     2155     2157    +2     
Files with missing lines Coverage Δ
simapp/app.go 66.09% <100.00%> (ø)
x/gov/keeper/keeper.go 80.28% <100.00%> (+0.28%) ⬆️
x/gov/keeper/proposal.go 80.37% <57.14%> (-2.26%) ⬇️

... and 1 file with indirect coverage changes

---- 🚨 Try these New Features:

@@ -3,6 +3,7 @@ package keeper_test
import (
"errors"
"fmt"
"github.com/cosmos/cosmos-sdk/x/params/types/proposal"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Lint

@philipsu522 philipsu522 changed the title Param change verif Param change verification Nov 13, 2024
@philipsu522 philipsu522 merged commit 042ea18 into main Nov 19, 2024
15 checks passed
@philipsu522 philipsu522 deleted the param-change-verif branch November 19, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants