Move allow list logic to msg server

[dssei]

Describe your changes and provide context

Move allow list logic to msg server

Testing performed to validate your change

• Unit tests
• Local chain functional tests

[codecov]

Codecov Report

Attention: Patch coverage is 45.45455% with 12 lines in your changes missing coverage. Please review.

Project coverage is 54.87%. Comparing base (71ec704) to head (4d5e05d).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
x/bank/keeper/msg_server.go	0.00%	12 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #550      +/-   ##
==========================================
- Coverage   54.89%   54.87%   -0.03%     
==========================================
  Files         631      631              
  Lines       54954    54926      -28     
==========================================
- Hits        30169    30138      -31     
- Misses      22628    22633       +5     
+ Partials     2157     2155       -2     

Files with missing lines	Coverage Δ
x/bank/keeper/send.go	87.23% <100.00%> (+1.20%)	⬆️
x/bank/keeper/msg_server.go	2.70% <0.00%> (-0.33%)	⬇️

... and 2 files with indirect coverage changes

[dssei]

Not the most efficient way to retrieve all module addresses and we may also want to cache it. So, I will look over the weekend how to improve this. I have also found we are passing some module addresses via blockedAddrs map[string]bool, that is being used for blocking some transactions though. And there is also module.Manager that may return them. @philipsu522 @codchen let me know what would the most efficient way.

[philipsu522]

yea i agree this might be too expensive. What about iterating through all modules (maybe app.go could expose this because we register all modules) and then calling

sei-cosmos/x/auth/keeper/keeper.go

Line 160 in 63ac1b2

func (ak AccountKeeper) GetModuleAddress(moduleName string) sdk.AccAddress {

on it? Not sure if @codchen has a better idea here though

[dssei]

Refactored, to avoid module checks altogether.
I think for this feature we should only be in business of controlling transfers for regular account/addresses, not modules, with transfers to modules implicitly not allowed via send. And we should not interfere with module->module, account->module and module->account flows.
The way to do this would be to move the allowlist logic to the message server and only do the checks in send and multisend.