Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete kvstore specified in store upgrades #533

Merged
merged 4 commits into from
Aug 20, 2024
Merged

Delete kvstore specified in store upgrades #533

merged 4 commits into from
Aug 20, 2024

Conversation

udpatil
Copy link
Contributor

@udpatil udpatil commented Aug 9, 2024

Describe your changes and provide context

Modify the behavior of storeloading to force load stores marked for deletion so that they don't need to be explicitly mounted in the chain app.go. This will allow for consistent store deletion across IAVL and seiDB-memIAVL and consistent resulting app hashes.

Testing performed to validate your change

Ongoing testing in a loadtest cluster

Copy link

codecov bot commented Aug 10, 2024

Codecov Report

Attention: Patch coverage is 56.52174% with 10 lines in your changes missing coverage. Please review.

Project coverage is 54.84%. Comparing base (0831407) to head (391818f).
Report is 1 commits behind head on main.

Files Patch % Lines
storev2/rootmulti/store.go 0.00% 10 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #533      +/-   ##
==========================================
- Coverage   54.84%   54.84%   -0.01%     
==========================================
  Files         631      631              
  Lines       54791    54811      +20     
==========================================
+ Hits        30050    30060      +10     
- Misses      22589    22599      +10     
  Partials     2152     2152              
Files Coverage Δ
store/rootmulti/store.go 71.69% <100.00%> (+0.35%) ⬆️
types/accesscontrol/resource.go 0.00% <ø> (ø)
storev2/rootmulti/store.go 2.61% <0.00%> (-0.05%) ⬇️

@udpatil udpatil merged commit a1d14b1 into main Aug 20, 2024
15 checks passed
@udpatil udpatil deleted the delete-kv-store branch August 20, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants