handle oracle overflow and rounding to zero for extreme values with cross rates #1983
+77
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1983 +/- ##
==========================================
- Coverage 61.64% 61.50% -0.15%
==========================================
Files 365 263 -102
Lines 26178 24339 -1839
==========================================
- Hits 16138 14970 -1168
+ Misses 8967 8256 -711
- Partials 1073 1113 +40
|
x/oracle/abci.go
Outdated
| @@ -66,6 +66,10 @@ func MidBlocker(ctx sdk.Context, k keeper.Keeper) { | |||
| voteMapRD := ballotRD.ToMap() | |||
|
|
|||
| exchangeRateRD := ballotRD.WeightedMedianWithAssertion() | |||
| // handle case where exchange rate is 0 | |||
| if exchangeRateRD.IsZero() { | |||
| // TODO: do stuff | |||
There was a problem hiding this comment.
do we actually want to do things?
There was a problem hiding this comment.
yeah I realized this one can't actually be zero because votes submitted with a zero value are modified to have the vote power set to 0, so the only way to get 0 exchange rates is for really small number divided by really large number which is with the cross rates calculations.
stevenlanders
approved these changes
Dec 9, 2024
udpatil
force-pushed
the
oracle-fix-division
branch
from
6048916 to
5324d78
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
This fixes issues that can occur in the most extreme circumstances where extreme values used for cross rates can cause issues during oracle ballot calculations.
Testing performed to validate your change
Unit test + docker cluster testing