Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

side_channels: Add SLH DSA report #238

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

side_channels: Add SLH DSA report #238

wants to merge 16 commits into from

Conversation

aewag
Copy link
Collaborator

@aewag aewag commented Oct 11, 2024

No description provided.

@reneme reneme added this to the Botan 3.6.0 milestone Oct 22, 2024
@reneme reneme force-pushed the aisec/sca/slh-dsa branch from a1ce11e to d9fac0c Compare October 29, 2024 14:32
@reneme reneme changed the base branch from release/3.5.0 to main October 29, 2024 14:33
@reneme
Copy link
Collaborator

reneme commented Oct 29, 2024 •
edited
Loading

@aewag I rebased this draft to the currrent main branch and re-targetted the pull request onto main as well. Please be aware when you continue working on this.

Also, I fixed a few minor things and used the :srcref: extension in explicit commits.

@reneme reneme mentioned this pull request Oct 29, 2024
Merged
@reneme reneme force-pushed the aisec/sca/slh-dsa branch from d9fac0c to 3b7dd03 Compare October 29, 2024 15:20
@reneme reneme mentioned this pull request Oct 29, 2024
Draft
@falsecurity falsecurity marked this pull request as ready for review November 18, 2024 02:07
@FAlbertDev FAlbertDev self-requested a review November 18, 2024 14:08
FAlbertDev
FAlbertDev reviewed Nov 18, 2024
View reviewed changes
Copy link
Collaborator

@FAlbertDev FAlbertDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I've mainly got some en-US vs. en-GB remarks. The execution difference description sounds sensible 👍 Thanks!

docs/audit_report/src/side_channels/01_04_slh_dsa.rst Outdated Show resolved Hide resolved
docs/audit_report/src/side_channels/01_04_slh_dsa.rst Outdated Show resolved Hide resolved
docs/audit_report/src/side_channels/01_04_slh_dsa.rst Outdated Show resolved Hide resolved
docs/audit_report/src/side_channels/01_04_slh_dsa.rst Outdated Show resolved Hide resolved
docs/audit_report/src/side_channels/01_04_slh_dsa.rst Outdated Show resolved Hide resolved
docs/audit_report/src/side_channels/01_04_slh_dsa.rst Outdated Show resolved Hide resolved
docs/audit_report/src/side_channels/01_04_slh_dsa.rst Outdated Show resolved Hide resolved
docs/audit_report/src/side_channels/01_04_slh_dsa.rst Outdated Show resolved Hide resolved
docs/audit_report/src/side_channels/01_04_slh_dsa.rst Outdated Show resolved Hide resolved
aewag and others added 10 commits November 21, 2024 13:20
@aewag @FAlbertDev
Update docs/audit_report/src/side_channels/01_04_slh_dsa.rst
4a4dbb8 
Co-authored-by: Fabian Albert <[email protected]>
@aewag @FAlbertDev
Update docs/audit_report/src/side_channels/01_04_slh_dsa.rst
b0c19ea 
Co-authored-by: Fabian Albert <[email protected]>
@aewag @FAlbertDev
Update docs/audit_report/src/side_channels/01_04_slh_dsa.rst
9cd7684 
Co-authored-by: Fabian Albert <[email protected]>
@aewag @FAlbertDev
Update docs/audit_report/src/side_channels/01_04_slh_dsa.rst
cde2dec 
Co-authored-by: Fabian Albert <[email protected]>
@aewag @FAlbertDev
Update docs/audit_report/src/side_channels/01_04_slh_dsa.rst
9441f50 
Co-authored-by: Fabian Albert <[email protected]>
@aewag @FAlbertDev
Update docs/audit_report/src/side_channels/01_04_slh_dsa.rst
14f7d77 
Co-authored-by: Fabian Albert <[email protected]>
@aewag @FAlbertDev
Update docs/audit_report/src/side_channels/01_04_slh_dsa.rst
8d0fa10 
Co-authored-by: Fabian Albert <[email protected]>
@aewag @FAlbertDev
Update docs/audit_report/src/side_channels/01_04_slh_dsa.rst
d0f9a8b 
Co-authored-by: Fabian Albert <[email protected]>
@aewag
sca: Add SLH-DSA variant
a746f7d
@aewag
sca: SLH-DSA clarify about auth_data
0b79f54
FAlbertDev
FAlbertDev approved these changes Dec 17, 2024
View reviewed changes
Copy link
Collaborator

@FAlbertDev FAlbertDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update! Looks good to me 👍

docs/audit_report/src/side_channels/01_04_slh_dsa.rst Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FAlbertDev FAlbertDev FAlbertDev approved these changes

Assignees
No one assigned
Labels
auditreport side channel report
Projects
None yet
Milestone
Botan 3.6.1
Development

Successfully merging this pull request may close these issues.
3 participants
@aewag @reneme @FAlbertDev