-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Check Patch Audit Compliance #167
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reneme
force-pushed
the
ci/check_patch_compliance
branch
2 times, most recently
from
December 12, 2023 13:57
b75dbeb
to
8c89a77
Compare
For reference: the current result is this:
|
Merged
FAlbertDev
approved these changes
Dec 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Exactly what I was looking for 👍
Currently, it validates: 1. Is the patch authored, approved or audited by at least one authorative auditor, registered in config/auditors.yml 2. Is the patch classified regarding its relevance to the library's overall security
reneme
force-pushed
the
ci/check_patch_compliance
branch
from
December 13, 2023 08:14
16fd067
to
881b792
Compare
After merging all remaining audit pull requests, I rebased to Edit: worked!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an automated check to ensure that all referenced patches in the audit document are sufficiently denoted to assume that an audit was performed on it.
Note that I had to install
pyyaml
forauditinfo
. Therefore, I needed topoetry update
all downstream dependencies. Hence: sorry for thepoetry.lock
clutter in this PR.Currently, this checks:
Note that we should not merge this until all currently registered patches are properly audited. Otherwise the
main
branch won't build anymore. As a side-effect this will also fail the Auto-Update pull request after the Bot created it. It will only turn green once an auditor clones it and performs an audit on the detected upstream patches.