Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abort Sphinx build on warnings #165

Merged
merged 1 commit into from
Dec 12, 2023
Merged

Abort Sphinx build on warnings #165

merged 1 commit into from
Dec 12, 2023

Conversation

reneme
Copy link
Collaborator

@reneme reneme commented Dec 11, 2023

-W is "treat sphinx warnings as errors". For instance, a reference that cannot be resolved is a warning and won't fail the build, otherwise. Locally, the PDF generator produces so much terminal-barf that warnings are often overlooked, despite being rendered in a different color.

--keep-going doesn't immediately stop on the first error. That is useful in CI, because it shows all the broken things to be fixed. Hopefully, that makes the "fix, commit, push, CI-fail"-cycle shorter.

Side note: CI now fails because the underlying main branch currently produces a warning that is fixed in #164.

@reneme reneme added the enhancement New feature or request label Dec 11, 2023
@reneme reneme requested review from lieser and FAlbertDev December 11, 2023 16:08
@reneme reneme self-assigned this Dec 11, 2023
docs/audit_report/Makefile Show resolved Hide resolved
@reneme reneme merged commit 9c14f76 into main Dec 12, 2023
17 of 22 checks passed
@reneme reneme deleted the ci/warnings_are_errors branch December 12, 2023 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants