-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Botan 3.2.0: Prepare Documents for Submission #143
Conversation
91caf2f
to
edd79f2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some grammar nitpicks. The content looks good to me 👍
1d32ee5
to
c918204
Compare
Co-authored-by: Fabian Albert <[email protected]>
1966c52
to
d18b05a
Compare
And implement a script to make this process easier next time
d18b05a
to
86bc57c
Compare
components. For the library implementation itself (``src/lib``), all modules | ||
that are *required* or *available* in the BSI build policy and their | ||
dependencies are in the scope of this document. Additionally, we review the | ||
following modules and its dependencies: ``aes_armv8``, ``aes_ni``, | ||
``aes_power8``, ``aes_vperm``, ``argon2_avx2``, ``argon2_ssse3``, | ||
``certstor_flatfile``, ``certstor_sql``, ``certstor_sqlite3``, | ||
``certstor_system``, ``certstor_system_macos``, ``certstor_system_windows``, | ||
``dilithium``, ``dilithium_aes``, ``ffi``, ``ghash_cpu``, ``ghash_vperm``, | ||
``keccak_perm_bmi2``, ``kyber``, ``kyber_90s``, ``pkcs11``, ``sha1_armv8``, | ||
``sha1_sse2``, ``sha1_x86``, ``sha2_32_armv8``, ``sha2_32_bmi2``, | ||
``sha2_32_x86``, ``sha2_64_bmi2``, ``shake``, ``sphincsplus_sha2``, | ||
``sphincsplus_shake``, ``tls_cbc``, ``tls12``, ``tls13``, ``tls13_pqc``, | ||
``xts``. Patches that don't alter any of the above-mentioned components or | ||
relevant modules are considered out-of-scope. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This list of additional modules also contains the if_available
modules of the BSI policy, like aes_armv8
, for example. We do not want that, do we?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its basically the list of both the "platform dependent modules" and the "additional modules" from the script. Though, you're right, the former is actually covered by the policy and probably doesn't need to show up here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the following (platform dependent) modules should still be in this list, as they are not in the BSI policy nor a requirement of any of the modules:
certstor_system_macos
certstor_system_windows
certstor_sqlite3
sha1_armv8
sha1_sse2
sha1_x86
Basically all modules that we review but that would need to be explicitly mentioned in --enable-modules=
to be enabled.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mhm, fair enough. I'll open a pull request for those.
Edit: #149
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All in all LGTM. Only some optics and nits.
Fixed your remarks, except the overflowing table. Yikes, I don't want to workaround that. We should all just get used to HTML. 😭 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Botan 3.2.0 was released today (09th October 2023). This adds final touches to the documents prior to the submission.
This includes:
audit_report
documentaudit_method
document (Move Method Description of DATA-based Side Channel Analysis to Audit Method Document #108)Probably it makes sense to go through the individual commits of this pull request.
closes #108.