-
Notifications
You must be signed in to change notification settings - Fork 797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for offsetdelete #1010
Support for offsetdelete #1010
Conversation
Hi @a-dot, Thanks for the contribution! You can use a construct like kafka-go/createpartitions_test.go Line 11 in d8dd9b0
|
Awesome! Thanks for the tip. I fixed that. |
Any hints as to why the tests fail on kafka-271 would be appreciated. Unless I'm mistaken, it doesn't look like it's my test that is failing? |
The test failure looked like some unrelated flakiness. I re-ran the failed job and it looks good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Closes #1009
The tests need kafka 2.4 to successfully run.