Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for offsetdelete #1010

Merged
merged 5 commits into from
Oct 21, 2022
Merged

Conversation

a-dot
Copy link
Contributor

@a-dot a-dot commented Oct 15, 2022

Closes #1009

The tests need kafka 2.4 to successfully run.

@rhansen2 rhansen2 self-assigned this Oct 21, 2022
@rhansen2
Copy link
Collaborator

Hi @a-dot,

Thanks for the contribution! You can use a construct like

if !ktesting.KafkaIsAtLeast("1.0.1") {
to gate your tests around the proper kafka versions.

@a-dot
Copy link
Contributor Author

a-dot commented Oct 21, 2022

Hi @a-dot,

Thanks for the contribution! You can use a construct like

if !ktesting.KafkaIsAtLeast("1.0.1") {

to gate your tests around the proper kafka versions.

Awesome! Thanks for the tip. I fixed that.

@a-dot
Copy link
Contributor Author

a-dot commented Oct 21, 2022

Any hints as to why the tests fail on kafka-271 would be appreciated. Unless I'm mistaken, it doesn't look like it's my test that is failing?

protocol/offsetdelete/offsetdelete_test.go Outdated Show resolved Hide resolved
offsetdelete.go Outdated Show resolved Hide resolved
protocol/offsetdelete/offsetdelete_test.go Outdated Show resolved Hide resolved
@rhansen2
Copy link
Collaborator

The test failure looked like some unrelated flakiness. I re-ran the failed job and it looks good.

Copy link
Collaborator

@rhansen2 rhansen2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rhansen2 rhansen2 merged commit 7501938 into segmentio:main Oct 21, 2022
@a-dot a-dot deleted the support-for-offsetdelete branch October 21, 2022 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for offsetdelete
2 participants