Pre-commit hook: pin goimports and allow customized arguments #122
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two minor propositions for the pre-commit configuration:
additional_dependencies
option to installgoimports
into the isolated environments thatpre-commit
creates for each hook. This makes the hook independent on a system-wide or$GOBIN
installation ofgoimports
, and allows for a portable configuration of pre-commit checks. The hook then also works, ifgoimports
is not already installed on the system where the hook runs.entry
point from itsargs
. This allows users to fully customise howgolines
is invoked in their localpre-commit
configuration. Sinceentry
can't be overridden, moving-w .
intoargs
gives users control the entire invocation. Arguably, this might make the hook harder to use, becauseargs: [-m, 80]
works well without this patch, and with the patch it has to beargs: [-m, 80, -w, .]
. I'm happy to remove this second change, if the control/simplicity tradeoff undesired. Example customisation: