Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mapping of createdAt -> $created #238

Merged
merged 1 commit into from
Jan 20, 2015
Merged

Fix mapping of createdAt -> $created #238

merged 1 commit into from
Jan 20, 2015

Conversation

fatuhoku
Copy link
Contributor

@fatuhoku fatuhoku commented Jan 6, 2015

See expected behaviour from documentation:

https://segment.com/docs/api/tracking/identify/#special-traits

Untested.

@lambtron
Copy link

lambtron commented Jan 6, 2015

More information:

Segment’s createdAt made a createdAt field in Mixpanel, with the relevant date string that I set through Segment, even though it’s supposed to just update $createdAt.

http://imgur.com/ZWbak2I

In the image above, createdAt is created when call is made to Segment (yesterday), but it should have just updated the other field.

@travisjeffery
Copy link
Contributor

Thanks!

travisjeffery pushed a commit that referenced this pull request Jan 20, 2015
Merge pull request #238 from fatuhoku/patch-1
13d4488 
Fix mapping of createdAt -> $created
@travisjeffery travisjeffery merged commit 13d4488 into segmentio:master Jan 20, 2015
travisjeffery pushed a commit that referenced this pull request Feb 11, 2015
Merge pull request #238 from fatuhoku/patch-1
4f25890 
Fix mapping of createdAt -> $created
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fatuhoku @lambtron @travisjeffery